Fork me on GitHub
Built by Maven

Checkstyle Results

The following document contains the results of Checkstyle 12.3.1 with sun_checks.xml ruleset.

Summary

Files  Info  Warnings  Errors
6 0 0 49

Files

File  I  W  E
edu/pdx/cs/joy/phonebill/PhoneBill.java 0 0 10
edu/pdx/cs/joy/phonebill/PhoneBillDAO.java 0 0 13
edu/pdx/cs/joy/phonebill/PhoneCall.java 0 0 8
edu/pdx/cs/joy/phonebill/Project1.java 0 0 7
edu/pdx/cs/joy/phonebill/TextDumper.java 0 0 6
edu/pdx/cs/joy/phonebill/TextParser.java 0 0 5

Rules

Category Rule Violations Severity
coding HiddenField 4  Error
design DesignForExtension 9  Error
HideUtilityClassConstructor 1  Error
imports AvoidStarImport 1  Error
javadoc JavadocPackage 1  Error
JavadocStyle 1  Error
JavadocVariable 4  Error
MissingJavadocMethod 5  Error
misc FinalParameters 12  Error
NewlineAtEndOfFile 1  Error
sizes LineLength
  • fileExtensions: "java"
 8  Error
whitespace OperatorWrap 2  Error

Details

edu/pdx/cs/joy/phonebill/PhoneBill.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 8
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 10
 Error misc FinalParameters Parameter customer should be final. 10
 Error coding HiddenField 'customer' hides a field. 10
 Error design DesignForExtension Class 'PhoneBill' looks like designed for extension (can be subclassed), but the method 'getCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PhoneBill' final or making the method 'getCustomer' static/final/abstract/empty, or adding allowed annotation for the method. 14
 Error design DesignForExtension Class 'PhoneBill' looks like designed for extension (can be subclassed), but the method 'addPhoneCall' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PhoneBill' final or making the method 'addPhoneCall' static/final/abstract/empty, or adding allowed annotation for the method. 19
 Error misc FinalParameters Parameter call should be final. 20
 Error sizes LineLength Line is longer than 80 characters (found 82). 21
 Error design DesignForExtension Class 'PhoneBill' looks like designed for extension (can be subclassed), but the method 'getPhoneCalls' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PhoneBill' final or making the method 'getPhoneCalls' static/final/abstract/empty, or adding allowed annotation for the method. 24
 Error sizes LineLength Line is longer than 80 characters (found 82). 26

edu/pdx/cs/joy/phonebill/PhoneBillDAO.java

Severity Category Rule Message Line
 Error imports AvoidStarImport Using the '.*' form of import should be avoided - java.sql.*. 6
 Error javadoc JavadocVariable Missing a Javadoc comment. 17
 Error misc FinalParameters Parameter connection should be final. 24
 Error coding HiddenField 'connection' hides a field. 24
 Error misc FinalParameters Parameter connection should be final. 34
 Error whitespace OperatorWrap '+' should be on a new line. 36
 Error whitespace OperatorWrap '+' should be on a new line. 37
 Error misc FinalParameters Parameter bill should be final. 51
 Error misc FinalParameters Parameter customerName should be final. 67
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 84
 Error misc FinalParameters Parameter args should be final. 84
 Error sizes LineLength Line is longer than 80 characters (found 96). 92
 Error sizes LineLength Line is longer than 80 characters (found 95). 101

edu/pdx/cs/joy/phonebill/PhoneCall.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error design DesignForExtension Class 'PhoneCall' looks like designed for extension (can be subclassed), but the method 'getCaller' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PhoneCall' final or making the method 'getCaller' static/final/abstract/empty, or adding allowed annotation for the method. 6
 Error sizes LineLength Line is longer than 80 characters (found 82). 8
 Error design DesignForExtension Class 'PhoneCall' looks like designed for extension (can be subclassed), but the method 'getCallee' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PhoneCall' final or making the method 'getCallee' static/final/abstract/empty, or adding allowed annotation for the method. 11
 Error design DesignForExtension Class 'PhoneCall' looks like designed for extension (can be subclassed), but the method 'getBeginTimeString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PhoneCall' final or making the method 'getBeginTimeString' static/final/abstract/empty, or adding allowed annotation for the method. 16
 Error sizes LineLength Line is longer than 80 characters (found 82). 18
 Error design DesignForExtension Class 'PhoneCall' looks like designed for extension (can be subclassed), but the method 'getEndTimeString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PhoneCall' final or making the method 'getEndTimeString' static/final/abstract/empty, or adding allowed annotation for the method. 21
 Error sizes LineLength Line is longer than 80 characters (found 82). 23

edu/pdx/cs/joy/phonebill/Project1.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error javadoc JavadocStyle First sentence should end with a period. 5
 Error design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 8
 Error misc FinalParameters Parameter dateAndTime should be final. 11
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 15
 Error misc FinalParameters Parameter args should be final. 15
 Error sizes LineLength Line is longer than 80 characters (found 118). 16

edu/pdx/cs/joy/phonebill/TextDumper.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 12
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 14
 Error misc FinalParameters Parameter writer should be final. 14
 Error coding HiddenField 'writer' hides a field. 14
 Error design DesignForExtension Class 'TextDumper' looks like designed for extension (can be subclassed), but the method 'dump' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TextDumper' final or making the method 'dump' static/final/abstract/empty, or adding allowed annotation for the method. 18
 Error misc FinalParameters Parameter bill should be final. 19

edu/pdx/cs/joy/phonebill/TextParser.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 14
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 16
 Error misc FinalParameters Parameter reader should be final. 16
 Error coding HiddenField 'reader' hides a field. 16
 Error design DesignForExtension Class 'TextParser' looks like designed for extension (can be subclassed), but the method 'parse' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TextParser' final or making the method 'parse' static/final/abstract/empty, or adding allowed annotation for the method. 20